Skip to content

Fix brace expansion with range going down #17591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RobinMalfait merged 6 commits into from
Apr 7, 2025
Merged

Fix brace expansion with range going down #17591

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7f747e5
hoist test to correct location
RobinMalfait Apr 7, 2025
9ed6cda
add similar test with negative step
RobinMalfait Apr 7, 2025
5b070c2
add step case indicator
RobinMalfait Apr 7, 2025
6d7dc9b
simplify loops to cover all cases
RobinMalfait Apr 7, 2025
01f022a
update changelog
RobinMalfait Apr 7, 2025
564dcce
add another test case
RobinMalfait Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
simplify loops to cover all cases
  • Loading branch information
@RobinMalfait
RobinMalfait committed Apr 7, 2025
commit 6d7dc9bdb6d416f3acb9ccd2d5a32fa3e147940e
17 changes: 7 additions & 10 deletions packages/tailwindcss/src/utils/brace-expansion.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,16 +78,13 @@ function expandSequence(seq: string): string[] {
if (step === 0) {
throw new Error('Step cannot be zero in sequence expansion.')
}
if (step > 0) {
for (let i = startNum; i <= endNum; i += step) {
let numStr = i.toString()
result.push(numStr)
}
} else {
for (let i = startNum; i >= endNum; i += step) {
let numStr = i.toString()
result.push(numStr)
}

let increasing = startNum < endNum
if (increasing && step < 0) step = -step
if (!increasing && step > 0) step = -step

for (let i = startNum; increasing ? i <= endNum : i >= endNum; i += step) {
result.push(i.toString())
}
}
return result
Expand Down