Skip to content

Prevent duplicate suggestions when using @theme and @utility together #17675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thecrypticace merged 4 commits into from
May 9, 2025
+42 −20
Merged

Prevent duplicate suggestions when using @theme and @utility together #17675

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8a4a60d
Add failing test
thecrypticace Apr 14, 2025
2e5e1f9
Ensure class suggestions are unique
thecrypticace Apr 14, 2025
57300d5
Update changelog
thecrypticace May 9, 2025
0dae0eb
Merge branch 'main' into fix/dupe-utility-suggestions
thecrypticace May 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add failing test
  • Loading branch information
@thecrypticace
thecrypticace committed May 9, 2025
commit 8a4a60d9fc8af71a7c7205ef839def1b6d69d51a
22 changes: 22 additions & 0 deletions packages/tailwindcss/src/intellisense.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -653,3 +653,25 @@ test('shadow utility default suggestions', async () => {
expect(classNames).toContain('inset-shadow')
expect(classNames).toContain('text-shadow')
})

test('Custom @utility and existing utility with names matching theme keys dont give duplicate results', async () => {
let input = css`
@theme reference {
--leading-sm: 0.25rem;
--text-header: 1.5rem;
}

@utility text-header {
text-transform: uppercase;
}
`

let design = await __unstable__loadDesignSystem(input)

let classList = design.getClassList()
let classMap = new Map(classList)
let matches = classList.filter(([className]) => className === 'text-header')

expect(matches).toHaveLength(1)
expect(classMap.get('text-header')?.modifiers).toEqual(['sm'])
})