Skip to content

Upgrade lightningcss to 1.30.0 #17979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
philipp-spiess merged 4 commits into from
May 12, 2025
Merged

Upgrade lightningcss to 1.30.0 #17979

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3c0d44c
Upgrade lightningcss
philipp-spiess May 12, 2025
a411e9b
Add change log
philipp-spiess May 12, 2025
9da66c3
Merge branch 'main' into chore/lightningcss
philipp-spiess May 12, 2025
25f2dc4
Merge remote-tracking branch 'origin/main' into chore/lightningcss
philipp-spiess May 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Allow `_` before numbers during candidate extraction ([#17961](https://github.com/tailwindlabs/tailwindcss/pull/17961))
- Upgrade: Fix error when using `@import … source(…)` ([#17963](https://github.com/tailwindlabs/tailwindcss/pull/17963))
- Prevent duplicate suggestions when using `@theme` and `@utility` together ([#17675](https://github.com/tailwindlabs/tailwindcss/pull/17675))
- Ensure that media queries within `::before` and `::after` pseudo selectors create valid CSS rules when building a production build ([#17979](https://github.com/tailwindlabs/tailwindcss/pull/17979))
- `lightningcss` now statically links Visual Studio redistributables ([#17979](https://github.com/tailwindlabs/tailwindcss/pull/17979))

## [4.1.6] - 2025-05-09

Expand Down
2 changes: 1 addition & 1 deletion integrations/vite/css-modules.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ describe.each(['postcss', 'lightningcss'])('%s', (transformer) => {
"tailwindcss": "workspace:^"
},
"devDependencies": {
${transformer === 'lightningcss' ? `"lightningcss": "^1.26.0",` : ''}
${transformer === 'lightningcss' ? `"lightningcss": "^1",` : ''}
"vite": "^6"
}
}
Expand Down
12 changes: 6 additions & 6 deletions integrations/vite/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ describe.each(['postcss', 'lightningcss'])('%s', (transformer) => {
"tailwindcss": "workspace:^"
},
"devDependencies": {
${transformer === 'lightningcss' ? `"lightningcss": "^1.26.0",` : ''}
${transformer === 'lightningcss' ? `"lightningcss": "^1",` : ''}
"vite": "^6"
}
}
Expand Down Expand Up @@ -110,7 +110,7 @@ describe.each(['postcss', 'lightningcss'])('%s', (transformer) => {
"tailwindcss": "workspace:^"
},
"devDependencies": {
${transformer === 'lightningcss' ? `"lightningcss": "^1.26.0",` : ''}
${transformer === 'lightningcss' ? `"lightningcss": "^1",` : ''}
"vite": "^6"
}
}
Expand Down Expand Up @@ -311,7 +311,7 @@ describe.each(['postcss', 'lightningcss'])('%s', (transformer) => {
"tailwindcss": "workspace:^"
},
"devDependencies": {
${transformer === 'lightningcss' ? `"lightningcss": "^1.26.0",` : ''}
${transformer === 'lightningcss' ? `"lightningcss": "^1",` : ''}
"vite": "^6"
}
}
Expand Down Expand Up @@ -490,7 +490,7 @@ describe.each(['postcss', 'lightningcss'])('%s', (transformer) => {
"tailwindcss": "workspace:^"
},
"devDependencies": {
${transformer === 'lightningcss' ? `"lightningcss": "^1.26.0",` : ''}
${transformer === 'lightningcss' ? `"lightningcss": "^1",` : ''}
"vite": "^6"
}
}
Expand Down Expand Up @@ -576,7 +576,7 @@ describe.each(['postcss', 'lightningcss'])('%s', (transformer) => {
"tailwindcss": "workspace:^"
},
"devDependencies": {
${transformer === 'lightningcss' ? `"lightningcss": "^1.26.0",` : ''}
${transformer === 'lightningcss' ? `"lightningcss": "^1",` : ''}
"vite": "^6"
}
}
Expand Down Expand Up @@ -678,7 +678,7 @@ describe.each(['postcss', 'lightningcss'])('%s', (transformer) => {
"tailwindcss": "workspace:^"
},
"devDependencies": {
${transformer === 'lightningcss' ? `"lightningcss": "^1.26.0",` : ''}
${transformer === 'lightningcss' ? `"lightningcss": "^1",` : ''}
"vite": "^6"
}
}
Expand Down
2 changes: 1 addition & 1 deletion integrations/vite/other-transforms.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ function createSetup(transformer: 'postcss' | 'lightningcss') {
"tailwindcss": "workspace:^"
},
"devDependencies": {
${transformer === 'lightningcss' ? `"lightningcss": "^1.26.0",` : ''}
${transformer === 'lightningcss' ? `"lightningcss": "^1",` : ''}
"vite": "^6"
}
}
Expand Down
4 changes: 2 additions & 2 deletions integrations/vite/resolvers.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ describe.each(['postcss', 'lightningcss'])('%s', (transformer) => {
"tailwindcss": "workspace:^"
},
"devDependencies": {
${transformer === 'lightningcss' ? `"lightningcss": "^1.26.0",` : ''}
${transformer === 'lightningcss' ? `"lightningcss": "^1",` : ''}
"vite": "^5.3.5"
}
}
Expand Down Expand Up @@ -82,7 +82,7 @@ describe.each(['postcss', 'lightningcss'])('%s', (transformer) => {
"tailwindcss": "workspace:^"
},
"devDependencies": {
${transformer === 'lightningcss' ? `"lightningcss": "^1.26.0",` : ''}
${transformer === 'lightningcss' ? `"lightningcss": "^1",` : ''}
"vite": "^5.3.5"
}
}
Expand Down
2 changes: 1 addition & 1 deletion integrations/vite/source-maps.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ test(
"tailwindcss": "workspace:^"
},
"devDependencies": {
"lightningcss": "^1.26.0",
"lightningcss": "^1",
"vite": "^6"
}
}
Expand Down
2 changes: 1 addition & 1 deletion integrations/vite/url-rewriting.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ describe.each(['postcss', 'lightningcss'])('%s', (transformer) => {
"tailwindcss": "workspace:^"
},
"devDependencies": {
${transformer === 'lightningcss' ? `"lightningcss": "^1.26.0",` : ''}
${transformer === 'lightningcss' ? `"lightningcss": "^1",` : ''}
"@tailwindcss/vite": "workspace:^",
"vite": "^6"
}
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
"packageManager": "[email protected]",
"pnpm": {
"patchedDependencies": {
"lightningcss@1.29.2": "patches/lightningcss@1.29.2.patch",
"lightningcss@1.30.0": "patches/lightningcss@1.30.0.patch",
"@parcel/[email protected]": "patches/@[email protected]"
}
}
Expand Down
5 changes: 4 additions & 1 deletion packages/tailwindcss/src/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5278,7 +5278,6 @@ describe('`color-mix(…)` polyfill', () => {

.shadow-xl {
--tw-shadow: 0 6px 18px 4px var(--tw-shadow-color, #ff000040);
box-shadow: var(--tw-inset-shadow), var(--tw-inset-ring-shadow), var(--tw-ring-offset-shadow), var(--tw-ring-shadow), var(--tw-shadow);
}

@supports (color: color-mix(in lab, red, red)) {
Expand All @@ -5287,6 +5286,10 @@ describe('`color-mix(…)` polyfill', () => {
}
}

.shadow-xl {
box-shadow: var(--tw-inset-shadow), var(--tw-inset-ring-shadow), var(--tw-ring-offset-shadow), var(--tw-ring-shadow), var(--tw-shadow);
}
Comment on lines +5289 to +5291
Copy link
Member

@RobinMalfait RobinMalfait May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, what happened here 🤔

Copy link
Contributor Author

@philipp-spiess philipp-spiess May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fixing an issue in ordering where previously the --tw-shadow could sometimes appear after the box-shadow assignment because of how @supports was resolved. This generates more code now but it's corrent in a sense that even if the supports query works, the assignment is in the right order still.

Copy link
Member

@RobinMalfait RobinMalfait May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that's fair, just an interesting change. I would be smaller again if we didn't have the @supports but this is fine (and correct) so let's merge it!


@property --tw-shadow {
syntax: "*";
inherits: false;
Expand Down
Loading