Skip to content

Make candidate template migrations faster #18025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RobinMalfait merged 18 commits into from
May 15, 2025
Merged

Make candidate template migrations faster #18025

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
d1b1143
cache candidate migrations
RobinMalfait May 14, 2025
62424b3
check safe migrations first
RobinMalfait May 14, 2025
5884994
add more safety checks
RobinMalfait May 14, 2025
283392f
migrate the candidate to its minimal form
RobinMalfait May 14, 2025
38bf86e
add `is-safe-migration` tests
RobinMalfait May 14, 2025
d512a41
remove `migrateImportant`
RobinMalfait May 14, 2025
e874a5e
move safe migration tests to `is-safe-migration` tests
RobinMalfait May 14, 2025
ebeff4f
drop `location` from `Migration` type
RobinMalfait May 14, 2025
660202a
add failing tests for #17974
RobinMalfait May 14, 2025
b6d36ee
do not perform migrations in `:attr="…"`
RobinMalfait May 14, 2025
754bccb
verify that the migrated class actually exists
RobinMalfait May 14, 2025
a495924
update changelog
RobinMalfait May 14, 2025
d526f33
improve safe migration check
RobinMalfait May 14, 2025
ac423ec
make `:` optional
RobinMalfait May 15, 2025
87e5e7a
ensure `group` and `peer` are valid during v3 migration
RobinMalfait May 15, 2025
535248f
fix integration test
RobinMalfait May 15, 2025
8fc683b
trigger CI
RobinMalfait May 15, 2025
75e0bf9
Merge branch 'main' into feat/make-candidate-migrations-faster
RobinMalfait May 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add failing tests for #17974
  • Loading branch information
@RobinMalfait
RobinMalfait committed May 14, 2025
commit 660202ab4ef4ef347cf1a124aa7b03f4d6dc3805
9 changes: 8 additions & 1 deletion packages/@tailwindcss-upgrade/src/codemods/template/is-safe-migration.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import { __unstable__loadDesignSystem } from '@tailwindcss/node'
import { expect, test } from 'vitest'
import { expect, test, vi } from 'vitest'
import * as versions from '../../utils/version'
import { migrateCandidate } from './migrate'
vi.spyOn(versions, 'isMajor').mockReturnValue(true)

test('does not replace classes in invalid positions', async () => {
let designSystem = await __unstable__loadDesignSystem('@import "tailwindcss";', {
Expand Down Expand Up @@ -51,4 +53,9 @@ test('does not replace classes in invalid positions', async () => {
await shouldNotReplace(`<Image placeholder="blur" src="/image.jpg" />`, 'blur')
await shouldNotReplace(`<Image placeholder={'blur'} src="/image.jpg" />`, 'blur')
await shouldNotReplace(`<Image placeholder={blur} src="/image.jpg" />`, 'blur')

// https://github.com/tailwindlabs/tailwindcss/issues/17974
await shouldNotReplace('<div v-if="!duration">', '!duration')
await shouldNotReplace('<div :active="!duration">', '!duration')
await shouldNotReplace('<div :active="!visible">', '!visible')
})