Skip to content

Fix false-positive migrations in addEventListener and JavaScript variable names #18718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thecrypticace merged 6 commits into from
Aug 12, 2025
+129 −56
Merged

Fix false-positive migrations in addEventListener and JavaScript variable names #18718

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5d99490
refactor is-safe-migration test
RobinMalfait Aug 11, 2025
d839a5f
add failing tests
RobinMalfait Aug 11, 2025
dc19148
ignore migrations in the event name of `addEventListener`
RobinMalfait Aug 11, 2025
67586f8
add "`" as valid quotes
RobinMalfait Aug 11, 2025
b9b0d28
check if we are in a string
RobinMalfait Aug 11, 2025
9784f7b
update changelog
RobinMalfait Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add "`" as valid quotes 
To be a bit more correct and consistent with the `addEventListener`
approach.
  • Loading branch information
@RobinMalfait
RobinMalfait committed Aug 11, 2025
commit 67586f870ea7b7b832b28648c1a1991b58403b36
4 changes: 2 additions & 2 deletions packages/@tailwindcss-upgrade/src/codemods/template/is-safe-migration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ const CONDITIONAL_TEMPLATE_SYNTAX = [
/x-show=['"]$/,
/wire:[^\s]*?$/,
]
const NEXT_PLACEHOLDER_PROP = /placeholder=\{?['"]$/
const VUE_3_EMIT = /\b\$?emit\(['"]$/
const NEXT_PLACEHOLDER_PROP = /placeholder=\{?['"`]$/
const VUE_3_EMIT = /\b\$?emit\(['"`]$/

export function isSafeMigration(
rawCandidate: string,
Expand Down