Skip to content

Skip comments in Ruby files when checking for class names #19243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thecrypticace merged 13 commits into from
Nov 13, 2025
+137 −5
Merged

Skip comments in Ruby files when checking for class names #19243

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
5c54516
Skip over strings in Ruby files
thecrypticace Oct 31, 2025
54617bc
Replace comments in Ruby code
thecrypticace Oct 31, 2025
a413e53
Discard arbitrary properties with `!` at the top-level
thecrypticace Oct 31, 2025
956ce18
Fix formatting
thecrypticace Oct 31, 2025
d9163d8
Add tests
thecrypticace Nov 11, 2025
3778c28
Support single line string literal specifiers
thecrypticace Nov 11, 2025
14f888f
Only match expected string literal specifiers
thecrypticace Nov 11, 2025
5662aaf
Fix formatting
thecrypticace Nov 11, 2025
f381118
Update changelog
thecrypticace Nov 12, 2025
7f34f3f
Handle `#` as a string format delimiter
thecrypticace Nov 12, 2025
54d4cac
Remove `!important` thing
thecrypticace Nov 13, 2025
defb469
Update comment
thecrypticace Nov 13, 2025
5ae0787
Update changelog
thecrypticace Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove !important thing
  • Loading branch information
@thecrypticace
thecrypticace committed Nov 13, 2025
commit 54d4cac6149ddecf20a89b4efcd415968c311010
9 changes: 1 addition & 8 deletions crates/oxide/src/extractor/arbitrary_property_machine.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,12 +234,6 @@ impl Machine for ArbitraryPropertyMachine<ParsingValueState> {
// An `!` at the top-level must be followed by "important" *and* be at the end
// otherwise its invalid
Class::Exclamation if self.bracket_stack.is_empty() => {
if cursor.input[cursor.pos..].starts_with(b"!important]") {
cursor.advance_by(10);

return self.done(self.start_pos, cursor);
}

return self.restart();
}

Expand Down Expand Up @@ -386,8 +380,7 @@ mod tests {
),
// A property containing `!` at the top-level is invalid
("[color:red!]", vec![]),
// Unless its part of `!important at the end
("[color:red!important]", vec!["[color:red!important]"]),
("[color:red!important]", vec![]),
] {
for wrapper in [
// No wrapper
Expand Down