Skip to content

Conversation

@thecrypticace
Copy link
Contributor

@thecrypticace thecrypticace commented Feb 24, 2022

Because we can't rely on preprocessors tracking imports as dependencies through PostCSS the only way we can reliably reuse the context is by using a hash of the CSS tree. This will let us invalidate the context when using tools like Sass with imports that contain @layer directives.

Fixes #4838

@thecrypticace thecrypticace force-pushed the fix/context-invalidation-on-content-change branch 3 times, most recently from 83d7e9e to 3cfb703 Compare February 25, 2022 13:36
@thecrypticace thecrypticace marked this pull request as ready for review February 25, 2022 14:59
@thecrypticace thecrypticace force-pushed the fix/context-invalidation-on-content-change branch from db4968d to 9121d40 Compare February 25, 2022 15:40
@thecrypticace thecrypticace force-pushed the fix/context-invalidation-on-content-change branch from 9121d40 to dc7b00a Compare February 25, 2022 15:45
@thecrypticace thecrypticace force-pushed the fix/context-invalidation-on-content-change branch from 0504e94 to e960034 Compare February 25, 2022 17:57
@thecrypticace thecrypticace force-pushed the fix/context-invalidation-on-content-change branch from e960034 to 7aea65f Compare February 25, 2022 18:03
@thecrypticace thecrypticace merged commit bd16763 into master Feb 25, 2022
@thecrypticace thecrypticace deleted the fix/context-invalidation-on-content-change branch February 25, 2022 18:12
@florianbouvot
Copy link
Contributor

florianbouvot commented Feb 25, 2022

@thecrypticace you will make a lot of Tailwind CSS users happy 🥳

I've try to remove Sass from my workflow and it's pretty good too.

Thanks a lot

@davidwebca
Copy link

Thank you for your hard work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SCSS @import directives nested inside @layer are not tracked

4 participants