Skip to content

Vector3<T> #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tannergooding merged 5 commits into from
Jun 13, 2020
Merged

Vector3<T> #2

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
51f0d47
Add Vector3<T>
HurricanKai Jun 12, 2020
800e3fd
Make Vector3<T> a struct
HurricanKai Jun 12, 2020
78da4f2
Fix IFormattable nullability
HurricanKai Jun 12, 2020
07f450f
Add XML Docs to Vector3<T>
HurricanKai Jun 12, 2020
b025476
Apply suggestions from code review
tannergooding Jun 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix IFormattable nullability
  • Loading branch information
@HurricanKai
HurricanKai committed Jun 12, 2020
commit 78da4f29426163ee107754f824832fb967404f31
4 changes: 2 additions & 2 deletions src/libraries/System.Private.CoreLib/src/System/Numerics/Vector3`1.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -665,8 +665,8 @@ public readonly void CopyTo(Span<T> destination)
public readonly T LengthSquared() => Dot(this, this);

public readonly override string ToString() => ToString("G");
public readonly string ToString(string format) => ToString(format, CultureInfo.CurrentCulture);
public readonly string ToString(string format, IFormatProvider formatProvider)
public readonly string ToString(string? format) => ToString(format, CultureInfo.CurrentCulture);
public readonly string ToString(string? format, IFormatProvider? formatProvider)
{
var sb = new StringBuilder();
string separator = NumberFormatInfo.GetInstance(formatProvider).NumberGroupSeparator;
Expand Down