JPEG-2000 export: overhaul to use OpenJPEG directly #715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lots of little kinks still to work out, but all the basic plumbing is in place and JP2 files are being created (mostly) correctly!
- JPEG-2000 images are now exported via OpenJPEG - JP2 export quality and speed is greatly improved by this commit - A number of JP2-specific export bugs have now been resolved - JP2 quality previews in the export dialog are now rendered in-memory via OpenJPEG, for greatly improved performance and greatly reduced memory requirements
JPEG-2000 and JPEG-XR export dialogs used very similar export quality text, differing only in the numbers used to represent quality levels (due to different quality scales). By merging these and supplying the numerical portions at run-time, I can cut ~20-something words and ~5 redundant phrases from all translation files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PhotoDemon now exports JPEG-2000 images using the 3rd-party OpenJPEG library:
https://www.openjpeg.org/
Prior to previous PD builds, this makes JPEG-2000 export faster, produces smaller and higher-quality files, and resolves a number of JP2-related bugs. Memory consumption has also been greatly reduced when exporting JP2 images, particularly when generating live previews (to reflect export quality). Grayscale, RGB, and RGBA export formats are all supported.
This closes out my current work on JPEG-2000 support in PhotoDemon. I think it's about as good as it gets for open-source software, but I am always open to additional feedback from users after wider testing.
Thank you to everyone who reported JPEG-2000-related bugs in the past! Your help made this overhaul possible.