enh: Add timerange expr type check and Relax the criteria for determi…

[Simon9997]

…ning external windows.

Description

Please briefly describe the code changes in this pull request.

Checklist

Please check the items in the checklist if applicable.

• Is the user manual updated?
• Are the test cases passed and automated?
• Is there no significant decrease in test coverage?

[gemini-code-assist]

Summary of Changes

Hello @Simon9997, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces an enhancement that improves the robustness of timerange expression handling by enforcing a timestamp type check. Concurrently, it relaxes the conditions for identifying external windows, which could lead to more flexible or efficient query planning and execution within the system.

Highlights

• Timerange Expression Type Check: A type check has been added to the filterExtractTsNeedCollect function in parTranslater.c to ensure that expressions evaluated for timerange filtering are explicitly of TSDB_DATA_TYPE_TIMESTAMP.
• Relaxed External Window Criteria: The criteria for determining external windows have been relaxed in the filterHasPlaceHolderRange function within planLogicCreater.c by removing a specific condition related to placeholder types, allowing for broader applicability.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces two enhancements: adding a type check for timerange expressions and relaxing the criteria for determining external windows. The changes appear correct and align with the PR's objectives. My review focuses on improving code readability and conciseness by simplifying boolean logic in both modified files.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ Simon9997
❌ dapan1121
_{You have signed the CLA already but the status is still pending? Let us recheck it.}