enh/redefine-show-vnodes-restored

[cadem]

Description

Please briefly describe the code changes in this pull request.

Jira: https://jira.taosdata.com:18080/browse/TD-

Checklist

Please check the items in the checklist if applicable.

• Is the user manual updated?
• Are the test cases passed and automated?
• Is there no significant decrease in test coverage?

[gemini-code-assist]

Summary of Changes

Hello @cadem, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the reporting and internal logic for the synchronization and readiness status of vnodes and vgroups. It introduces a clearer is_ready status for vgroups and renames the restored status to applied for vnodes, along with adjusting the underlying mechanisms that determine these states. The changes aim to provide more precise and consistent information about the operational status of distributed components.

Highlights

• Schema Update for Vgroups: A new boolean column named is_ready has been added to the vgroups system table schema to indicate the readiness status of vgroups.
• Vnode Status Renaming: The restored column in the vnodes system table schema has been renamed to applied to better reflect its meaning regarding data application status.
• Vgroup Readiness Logic: The logic for determining a vgroup's readiness has been implemented, setting is_ready to true if a leader or assigned leader vnode has completed its synchronization restoration. This also removes the * and ** indicators from the role column in show vgroups output.
• Refined Restoration Completion Logic: The conditions for marking a vnode's restoration as complete in the synchronization pipeline have been tightened, now explicitly requiring a valid log entry and consistent term.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refines the logic for determining the restored state of vnodes and introduces a new is_ready status for vgroups. The changes include adding an is_ready column to the vgroups system table, renaming the restored column to applied in the vnodes system table for better clarity, and implementing the logic to calculate the is_ready flag for a vgroup. Additionally, the condition for a node to be marked as 'restored' in the sync pipeline is strengthened, which improves the correctness of the system. The changes are well-implemented and improve both clarity and robustness. I approve of this pull request.