feat(TDgtp): Adjust requirements_ess to support Python 3.12#33894
feat(TDgtp): Adjust requirements_ess to support Python 3.12#33894guanshengliang merged 17 commits into3.0from
Conversation
Summary of ChangesHello @hjxilinx, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on updating the dependency requirements for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates pandas and adds scipy to requirements_ess.txt to support Python 3.12. While these changes are necessary, they introduce a couple of issues. First, adding scipy==1.15.0 creates a critical dependency conflict with requirements.txt, which will cause the installation to fail. Second, updating pandas to 2.2.0 creates an inconsistency with an older version hardcoded in a Dockerfile. Please see the detailed comments for suggestions on how to resolve these issues.
Description
feat: Adjust requirements_ess to support Python3.12
Issue(s)
Checklist
Please check the items in the checklist if applicable.