Skip to content

feat/TS-6863-add-use-token-para#34029

Merged
guanshengliang merged 3 commits into3.0from
feat/TS-6863-add-use-token-para
Dec 25, 2025
Merged

feat/TS-6863-add-use-token-para#34029
guanshengliang merged 3 commits into3.0from
feat/TS-6863-add-use-token-para

Conversation

@cadem
Copy link
Contributor

@cadem cadem commented Dec 24, 2025

Description

Issue(s)

  • Close/close/Fix/fix/Resolve/resolve: Issue Link

Checklist

Please check the items in the checklist if applicable.

  • Is the user manual updated?
  • Are the test cases passed and automated?
  • Is there no significant decrease in test coverage?

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @cadem, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new configuration parameter, auditUseToken, to enhance the flexibility of audit data reporting within the system. This parameter, intended for Enterprise use, allows for explicit control over whether a security token is utilized during the audit reporting process. The changes also include essential updates to the system's documentation in both English and Chinese to reflect this new feature, alongside a minor correction to the default value of an existing audit-related parameter.

Highlights

  • New Audit Configuration Parameter: Introduced auditUseToken, a new Enterprise parameter that controls whether a token is used for reporting audit data, with a default value of 1 (use token).
  • Documentation Updates: Added comprehensive documentation for the new auditUseToken parameter in both English (docs/en/14-reference/01-components/01-taosd.md) and Chinese (docs/zh/14-reference/01-components/01-taosd.md) reference manuals.
  • auditHttps Default Value Correction: Corrected the default value for the auditHttps parameter in the English documentation from 1 to 0.
  • Internal Code Integration: Integrated the auditUseToken parameter into the system's global variables, configuration loading, and dynamic configuration update mechanisms in include/common/tglobal.h and source/common/src/tglobal.c.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new configuration parameter auditUseToken to control whether a token is used for reporting audit data. The changes include adding the global variable and its configuration logic in the C source code, as well as updating the English and Chinese documentation to reflect this new parameter. The default value for auditHttps has also been corrected in the documentation.

The implementation is mostly correct, but I've found a minor inconsistency in the initialization of the new parameter when the audit feature is compiled out. Please see my specific comment for details.

@guanshengliang guanshengliang merged commit d3d5798 into 3.0 Dec 25, 2025
15 of 18 checks passed
@cadem cadem deleted the feat/TS-6863-add-use-token-para branch December 25, 2025 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants