fix(stream): uid cannot find in uidIndex because of numOfRows==0 & send msg to trigger if error happens in reader

[wangmm0220]

Description

Issue(s)

• Close/close/Fix/fix/Resolve/resolve: Issue Link
• https://project.feishu.cn/taosdata_td/defect/detail/6616813301

Checklist

Please check the items in the checklist if applicable.

• Is the user manual updated?
• Are the test cases passed and automated?
• Is there no significant decrease in test coverage?

[gemini-code-assist]

Summary of Changes

Hello @wangmm0220, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on enhancing the robustness and observability of the vnode stream processing logic. It introduces more granular debug logging to aid in diagnosing data submission and time range issues, refines the conditional execution of data processing steps, and implements a safeguard to ensure that all incoming RPC messages receive a response, thereby improving system reliability and debugging capabilities.

Highlights

• Improved Debug Logging: Added detailed debug logs in scanSubmitTbData and scanSubmitDataPre to provide better insights into time range processing and data submission, especially for scenarios where no valid data is found.
• Refined Data Submission Logic: Adjusted the scanSubmitTbData function to correctly handle cases where no valid data is present within a specified time range, ensuring logging and row counting are conditional on data availability.
• Ensured RPC Response Handling: Implemented a mechanism in vnodeProcessStreamReaderMsg to guarantee that an RPC response is always sent, even for unhandled or default message types, preventing potential hanging or unacknowledged requests.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds extensive debug logging and refactors the response handling logic in vnodeProcessStreamReaderMsg to prevent issues with missing or duplicate RPC responses. The use of the sendRsp flag is a good strategy for this. However, there is a critical flaw in the default case of the switch statement where a key statement is unreachable, which would lead to a missing response for unknown message types. The other changes, such as moving code into a conditional block and adjusting log levels, are correct and enhance the code's robustness and debuggability.