merge: from 3.3.6 to main

[guanshengliang]

Description

Issue(s)

• Close/close/Fix/fix/Resolve/resolve: Issue Link

Checklist

Please check the items in the checklist if applicable.

• Is the user manual updated?
• Are the test cases passed and automated?
• Is there no significant decrease in test coverage?

[gemini-code-assist]

Summary of Changes

Hello @guanshengliang, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates changes from the 3.3.6 branch into the main branch. The primary functional change involves increasing the capacity of the cacheload system table column and its corresponding C-code variable to handle larger integer values. Additionally, the PR includes updates to various test scripts, specifically adding data retention policies to database creation commands, which helps in maintaining consistent test environments and validating retention functionality.

Highlights

• Data Type Upgrade: The cacheload column in the vgroupsSchema has been upgraded from INT (4 bytes) to BIGINT (8 bytes) to support larger values.
• C Code Alignment: The cacheUsage variable in mndVgroup.c was updated from int32_t to int64_t to align with the BIGINT data type change for cacheload.
• Test Case Enhancements: Several test cases were modified to include a keep clause (e.g., keep 36500d) when creating databases, ensuring data retention policies are consistently applied and tested.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request appears to be a merge from a release branch, incorporating several bug fixes and test improvements. The core change involves increasing the size of the cacheload field from INT to BIGINT to prevent potential overflows, which is a sensible fix. The accompanying changes in test files enhance their robustness by ensuring a clean database state before execution and by setting long data retention periods to prevent data loss during tests. I've provided one suggestion to further improve a test file by adding error handling for setup queries, which will make debugging easier in case of failures.