merge: from 3.3.6 to main branch

[guanshengliang]

Description

Issue(s)

• Close/close/Fix/fix/Resolve/resolve: Issue Link

Checklist

Please check the items in the checklist if applicable.

• Is the user manual updated?
• Are the test cases passed and automated?
• Is there no significant decrease in test coverage?

[gemini-code-assist]

Summary of Changes

Hello @guanshengliang, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on enhancing data integrity during INSERT operations and standardizing database creation in test environments. It introduces a critical validation check to ensure that dynamically generated table names (tbname) are always of string type, preventing potential data corruption or parsing errors. Additionally, it updates existing test cases to include explicit data retention policies for newly created databases, improving test reliability and consistency.

Highlights

• tbname Type Validation: Implemented a new validation in the parser to ensure that when a table name (tbname) is generated using a function or expression within an INSERT statement, its resulting data type must be a string. This prevents incorrect data types from being used for table names and ensures data integrity.
• Database Retention Policy in Tests: Updated several test cases to explicitly include a keep 36500d clause when creating databases. This standardizes the data retention policy for test databases, preventing premature data deletion and improving test reliability.
• New Test Case for tbname Validation: Added a new test case (related to bugfix:6554558952) to verify the correct behavior of INSERT ... SELECT statements when generating tbname values. This test specifically checks that string-typed expressions for tbname are accepted, while non-string types (like floats) are correctly rejected with an error, confirming the new validation logic.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request primarily introduces a bug fix in the SQL parser to enforce that values for the tbname pseudo-column must be of a string type during INSERT ... SELECT operations. This is a good correctness improvement. The change is well-supported by a new test case that validates both successful string-based insertions and correctly fails non-string insertions. Additionally, several test files have been updated to set a long retention period on created databases, which is a good practice for improving test stability. Overall, the changes are correct and beneficial.