fix compile error

[yihaoDeng]

Description

Issue(s)

• Close/close/Fix/fix/Resolve/resolve: Issue Link

Checklist

Please check the items in the checklist if applicable.

• Is the user manual updated?
• Are the test cases passed and automated?
• Is there no significant decrease in test coverage?

[gemini-code-assist]

Summary of Changes

Hello @yihaoDeng, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a compilation issue by refining a string copy operation within the cloneDataTimeWhiteListRsp function. The change ensures that string data is safely copied into a destination buffer, preventing potential buffer overflows and improving code robustness.

Highlights

• Compile Error Fix: Corrected a strncpy usage in the cloneDataTimeWhiteListRsp function to prevent potential buffer overflows and ensure correct string copying by using sizeof(destUser->user) instead of strlen(srcUser->user).

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses a potential buffer over-read vulnerability by replacing strlen with sizeof in a strncpy call, which is a good improvement. However, strncpy itself can be unsafe as it does not guarantee null-termination if the source string's length is equal to or greater than the destination buffer size. I've suggested using snprintf as a safer alternative to ensure the string is always null-terminated, preventing potential buffer over-reads in subsequent operations.

[gemini-code-assist]

While using sizeof(destUser->user) is an improvement over strlen(srcUser->user) as it correctly uses the size of the destination buffer, strncpy can still lead to issues. If the source string srcUser->user has a length greater than or equal to sizeof(destUser->user), the destination buffer destUser->user will not be null-terminated. This can lead to buffer over-reads in subsequent operations that treat it as a C-string.

A safer alternative is to use snprintf, which guarantees null-termination.

    snprintf(destUser->user, sizeof(destUser->user), "%s", srcUser->user);

[Copilot]

Pull request overview

This PR fixes a compile error in the cloneDataTimeWhiteListRsp function by correcting the third parameter of a strncpy call from strlen(srcUser->user) to sizeof(destUser->user).

• Replaces incorrect use of strlen() with sizeof() for buffer size limit in strncpy

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The use of sizeof(destUser->user) is correct but inconsistent with the pattern used elsewhere in this file. Line 5308 uses the constant TSDB_USER_LEN instead: strncpy(pNew->user, src->user, TSDB_USER_LEN);. Consider using TSDB_USER_LEN for consistency, or alternatively ensure null-termination by using sizeof(destUser->user) - 1 followed by explicit null termination.

Suggested change

	strncpy(destUser->user, srcUser->user, sizeof(destUser->user));
	strncpy(destUser->user, srcUser->user, TSDB_USER_LEN);
	destUser->user[TSDB_USER_LEN - 1] = '\0';