Disable instance name prefix in logs when running interactively by mRrvz · Pull Request #463 · tarantool/cartridge-cli · GitHub

This repository was archived by the owner on Dec 1, 2025. It is now read-only.

Contributor

mRrvz commented Jan 28, 2021 •

edited

Loading

Added --no-log-prefix option for cartridge start command to disable instance name prefix in logs when running interactively. Closes #373

mRrvz changed the title ~~Ddisable instance(s) prefix in logs~~ Disable instance(s) prefix in logs

olegrok reviewed

View reviewed changes

Contributor

olegrok left a comment

Hi! Thanks for your patch. Consider several comments below.

Also please describe your changes in commit message - that you've done and why. Also it would be great to have some tests and changelog note.

Also please don't put any prefixes to your commit message title. The feature is not huge it will be merged as single commit: "allow to disable instance name prefix in logs" seems to be good enough.

cli/commands/common.go Outdated Show resolved Hide resolved

cli/running/writer.go Outdated Show resolved Hide resolved

Contributor

dokshina commented Jan 28, 2021

Maybe we can persist this flag? See #460

Contributor

olegrok commented Jan 28, 2021

Maybe we can persist this flag? See #460

Sorry, but do you have sufficient grounds for this?

It seems reasonable for stateboard but we shouldn't persist each option in my opinion

Contributor

dokshina commented Feb 2, 2021

Sorry, but do you have sufficient grounds for this?

Let's discuss it in #460

dokshina reviewed

View reviewed changes

cli/commands/common.go Outdated Show resolved Hide resolved

dokshina reviewed

View reviewed changes

cli/commands/start.go Outdated Show resolved Hide resolved

dokshina reviewed

View reviewed changes

cli/running/writer_test.go Outdated Show resolved Hide resolved

dokshina reviewed

View reviewed changes

cli/running/writer_test.go Outdated Show resolved Hide resolved

dokshina reviewed

View reviewed changes

cli/running/writer_test.go Outdated Show resolved Hide resolved

dokshina reviewed

View reviewed changes

test/utils.py Outdated Show resolved Hide resolved

dokshina reviewed

View reviewed changes

test/integration/running/test_running.py Outdated Show resolved Hide resolved

dokshina reviewed

View reviewed changes

cli/context/context.go Show resolved Hide resolved

dokshina reviewed

View reviewed changes

cli/commands/start.go Outdated Show resolved Hide resolved

dokshina reviewed

View reviewed changes

cli/commands/start.go Outdated Show resolved Hide resolved

dokshina reviewed

View reviewed changes

cli/commands/usage.go Outdated Show resolved Hide resolved

dokshina reviewed

View reviewed changes

test/utils.py Outdated Show resolved Hide resolved

dokshina reviewed

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

dokshina approved these changes

View reviewed changes

Contributor

dokshina left a comment

Good!

mRrvz added 7 commits

February 2, 2021 17:28


          ADD: disable instance(s) prefix in stdout logs feature

3a6951b


          PR fix && changelog

20005c1


          Tests

1d5219d


          Codestyle fix

f019c80


          Unit tets for no-prefix writer

9d8d5ee


          Fix PR issues

015c87a


          Fixing timeout and no-log-prefix flags logic

41cc7d0

mRrvz force-pushed the disable-prefix-in-logs-feature branch from 597e67b to 41cc7d0 Compare

February 2, 2021 14:29

mRrvz changed the title ~~Disable instance(s) prefix in logs~~ Disable instance name prefix in logs when running interactively

Contributor Author

mRrvz commented Feb 3, 2021

Added --no-log-prefix option for cartridge start command to disable instance name prefix in logs when running interactively. Closes #373

mRrvz merged commit f5d6557 into master

mRrvz deleted the disable-prefix-in-logs-feature branch

February 3, 2021 08:39

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet