internal: use a sync.Pool of msgpack.Decoder #440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-jukovec
force-pushed
the
oleg-jukovec/decoders-pool
branch
7 times, most recently
from
30cb74b to
62e5235
Compare
KaymeKaydex
suggested changes
Mar 30, 2025
The change helps to avoid 2 allocations per a response decoding. You could check the change with the command: $ go test -v . -bench . -run fff -benchmem
oleg-jukovec
force-pushed
the
oleg-jukovec/decoders-pool
branch
from
62e5235 to
542bfc9
Compare
KaymeKaydex
approved these changes
Mar 31, 2025
patapenka-alexey
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change helps to avoid 2 allocations per a response decoding.
You could check the change with the command: