Skip to content

get_cluster_vclock: delete zero vclock component #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

get_cluster_vclock: delete zero vclock component #369

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
get_cluster_vclock: delete zero vclock component 
Zero vclock component is used for local transactions and is meaningless
for cluster as a whole.
  • Loading branch information
@grafin
grafin committed Jan 23, 2023
commit 7311cd5a176300a6bfaae50343f216e0c450cdcb
1 change: 1 addition & 0 deletions test_run.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,7 @@ local function get_cluster_vclock(self, servers)
end
end
end
vclock[0] = nil
Copy link
Contributor

@ylobankov ylobankov Apr 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I understand, vclock is a table where keys are server IDs, values are lsn. How vclock[0] can exist?

Copy link
Member Author

@grafin grafin Apr 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vclock[0] is special: it stores lsn for local (non-replicated) entries.

return setmetatable(vclock, { __serialize = 'map' })
end

Expand Down