Skip to content

feat: Make taskgraph artifact prefix configurable (bug 1989274) #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
JohanLorenzo wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

feat: Make taskgraph artifact prefix configurable (bug 1989274) #778

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
900613f
feat: Make taskgraph artifact prefix configurable (bug 1989274)
JohanLorenzo Sep 18, 2025
625b82a
feat: Make docker image artifact paths configurable (bug 1989274)
JohanLorenzo Sep 18, 2025
e9fb295
Add conditional taskclusterProxy and scopes for docker-image tasks
JohanLorenzo Sep 19, 2025
a18203b
Fix taskcluster-proxy field name for schema validation
JohanLorenzo Sep 19, 2025
e28d98b
Fix schema and taskId format for external task images
JohanLorenzo Sep 19, 2025
2334c7c
Use dashed identifiers in YAML schema (task-id not taskId)
JohanLorenzo Sep 19, 2025
344e704
Add handling for external task image format in docker worker
JohanLorenzo Sep 19, 2025
de7ca2b
Fix docker-contexts artifact scope for private artifacts
JohanLorenzo Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat: Make docker image artifact paths configurable (bug 1989274)
  • Loading branch information
@JohanLorenzo
JohanLorenzo committed Oct 3, 2025
commit 625b82a80c6947a01ef19d2f9abff982a45e88f0
7 changes: 5 additions & 2 deletions src/taskgraph/transforms/docker_image.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
from taskgraph.transforms.base import TransformSequence
from taskgraph.util import json
from taskgraph.util.docker import create_context_tar, generate_context_hash
from taskgraph.util.taskcluster import get_artifact_prefix_from_parameters
from taskgraph.util.schema import Schema

from .task import task_description_schema
Expand Down Expand Up @@ -143,6 +144,8 @@ def fill_template(config, tasks):
f"Missing package job for {config.kind}-{image_name}: {p}"
)

artifact_prefix = get_artifact_prefix_from_parameters(config.params)

if not taskgraph.fast:
context_path = os.path.join("taskcluster", "docker", definition)
topsrcdir = os.path.dirname(config.graph_config.taskcluster_yml)
Expand Down Expand Up @@ -199,12 +202,12 @@ def fill_template(config, tasks):
{
"type": "file",
"path": "/workspace/out/image.tar.zst",
"name": "public/image.tar.zst",
"name": f"{artifact_prefix}/image.tar.zst",
}
],
"env": {
"CONTEXT_TASK_ID": {"task-reference": "<decision>"},
"CONTEXT_PATH": f"public/docker-contexts/{image_name}.tar.gz",
"CONTEXT_PATH": f"{artifact_prefix}/docker-contexts/{image_name}.tar.gz",
"HASH": context_hash,
"PROJECT": config.params["project"],
"IMAGE_NAME": image_name,
Expand Down