-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
feat(mobile): multi-window support #14484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lucasfernog
wants to merge
28
commits into
dev
Choose a base branch
from
feat/mobile-multi-window
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,705
−1,035
Open
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
57f9d56
feat(android): prepare for multi-window support
lucasfernog a71c707
add android multiwindow apis
lucasfernog f12df40
activity_name getter, JS API, auto inherit from manager on builder::new
lucasfernog c389ba4
refactor(core): improve iOS log messages from stdout/stderr
lucasfernog 9e0bbff
patch
lucasfernog 067ef61
Merge branch 'dev' into feat/mobile-multi-window
lucasfernog 6854f8b
Merge branch 'refactor/ios-stdout-stderr-log' into feat/mobile-multi-…
lucasfernog b5d874d
use context (created_by_activity_name) from caller on TS API
lucasfernog bcc25c0
add scene identifier getter and setter
lucasfernog e4ccc32
expose apis
lucasfernog 9a360af
fix desktop build
lucasfernog c5dbb02
Merge remote-tracking branch 'origin/dev' into feat/mobile-multi-window
lucasfernog 6b94116
fix window from config
lucasfernog a602008
update lock
lucasfernog eb51b13
size is now respected on iOS, so default to None
lucasfernog f5f9b3d
add SceneRequested event
lucasfernog 220cc2a
Merge remote-tracking branch 'origin/dev' into feat/mobile-multi-window
lucasfernog 6eb2dee
update features
lucasfernog bfc74a7
fix default size
lucasfernog e97e2e5
Revert "fix default size"
lucasfernog 11fc78b
ignore size from config
lucasfernog e5f65a6
lint
lucasfernog 1702b27
Merge remote-tracking branch 'origin/dev' into feat/mobile-multi-window
lucasfernog 2172252
use git
lucasfernog 7f953fc
change file
lucasfernog 7f02cf5
add supports_multiple_windows API
lucasfernog 12aaef6
add androidx.lifecycle:lifecycle-process
lucasfernog 00dcedc
update wry
lucasfernog File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix desktop build
- Loading branch information
commit 9a360af214fd22b30e69d37541c4f9f90e89ba7c
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apps can't currently detect if multi-window is available. Should we add an API like this? e.g.
Typescript
Rust
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea
7f02cf5