Skip to content

Validate put request json #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 17, 2025
Merged

Validate put request json #107

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9e1f388
Make sure to check that the blob exists before updating or deleting it.
tburch Jul 7, 2022
6ebec9b
bump version
tburch Jul 7, 2022
00b9e1f
Merge branch 'hotfix/1.0.2'
tburch Jul 7, 2022
94a2eef
Allow PUTs to create blobs as long as the id can be resolved
tburch May 6, 2023
bb703c1
switch to new GA
tburch Apr 6, 2024
17e4974
Fixes #106 - validate that PUT requests contain valid JSON
tburch Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Make sure to check that the blob exists before updating or deleting it. 
Fixes #99.
  • Loading branch information
@tburch
tburch committed Jul 7, 2022
commit 9e1f38876ccd33ac60794066405cf237cb343e8d
4 changes: 2 additions & 2 deletions src/main/kotlin/jsonblob/api/http/ApiController.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ class ApiController(
return false
}

private fun delete(blobId: String) = jsonBlobStore.remove(blobId)
private fun delete(blobId: String) = jsonBlobStore.exists(blobId) && jsonBlobStore.remove(blobId)

private fun updateFirstBlobFromPath(path: String, json: String): JsonBlob? {
val ids = blobIdsFromPath(path)
Expand All @@ -170,7 +170,7 @@ class ApiController(

private fun update(blobId: String, json: String): JsonBlob? {
val resolver = idResolvers.firstOrNull { it.handles(blobId) }
return if (resolver != null) {
return if (resolver != null && jsonBlobStore.exists(blobId)) {
val created = resolver.resolveTimestamp(blobId)
val jsonBlob = JsonBlob(
id = blobId,
Expand Down