Skip to content

Conversation

@tcheeric
Copy link
Owner

Summary

  • document factory/registry architecture for creating and extending events
  • describe how to add new event types, testing expectations, and contribution guidelines

Testing

  • mvn -q verify (fails: Could not find a valid Docker environment)

https://chatgpt.com/codex/tasks/task_b_68a48d9f22bc8331984698e3e71fb433

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@tcheeric tcheeric requested a review from Copilot August 19, 2025 16:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Documents the project's architecture for extending events using factories and registries, providing guidelines for contributors who want to add new event types to the Nostr implementation.

  • Documents the factory/registry pattern used for event creation and tag management
  • Provides step-by-step instructions for adding new event types
  • Establishes testing and contribution requirements

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

- Include comprehensive tests for new functionality and remove unused imports.
- Summaries of changes and test results are expected in pull requests.

Refer to the repository's `AGENTS.md` for the full list of contribution expectations.
Copy link

Copilot AI Aug 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reference to AGENTS.md appears to be a non-standard filename for contribution guidelines. Consider verifying this filename exists or if it should be CONTRIBUTING.md which is the conventional name for contribution guidelines.

Suggested change
Refer to the repository's `AGENTS.md` for the full list of contribution expectations.
Refer to the repository's `CONTRIBUTING.md` for the full list of contribution expectations.

Copilot uses AI. Check for mistakes.
@tcheeric tcheeric merged commit c80737b into develop Aug 19, 2025
3 checks passed
@tcheeric tcheeric deleted the codex/create-documentation-for-extending-events branch August 19, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants