-
Notifications
You must be signed in to change notification settings - Fork 26
docs: document NIPs and PR template usage #394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tcheeric
merged 3 commits into
develop
from
codex/update-agents.md-with-pr-quality-gate-rules
Aug 19, 2025
Merged
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,5 +1,97 @@ | ||||||
| # Repo Guidelines | ||||||
|
|
||||||
| ## NIPs | ||||||
|
|
||||||
| - https://github.com/nostr-protocol/nips/blob/master/01.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/02.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/03.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/04.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/05.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/06.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/07.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/08.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/09.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/10.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/11.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/12.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/13.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/14.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/15.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/16.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/17.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/18.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/19.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/20.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/21.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/22.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/23.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/24.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/25.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/26.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/27.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/28.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/29.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/30.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/31.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/32.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/33.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/34.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/35.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/36.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/37.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/38.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/39.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/40.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/42.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/44.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/45.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/46.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/47.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/48.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/49.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/50.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/51.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/52.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/53.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/54.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/55.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/56.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/57.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/58.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/59.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/60.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/61.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/62.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/64.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/65.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/66.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/68.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/69.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/70.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/71.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/72.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/73.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/75.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/77.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/78.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/7D.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/84.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/86.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/87.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/88.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/89.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/90.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/92.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/94.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/96.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/98.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/99.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/A0.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/B0.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/B7.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/C0.md | ||||||
| - https://github.com/nostr-protocol/nips/blob/master/C7.md | ||||||
|
|
||||||
| ## Description | ||||||
| nostr-java is a java implementation of the nostr protocol. The specification is available on github, here: https://github.com/nostr-protocol/nips | ||||||
| The URL format for the NIPs is https://github.com/nostr-protocol/nips/blob/master/XX.md where XX is the NIP number. For example, the specification for NIP-01 is available at the URL https://github.com/nostr-protocol/nips/blob/master/01.md etc. | ||||||
|
|
@@ -23,7 +115,19 @@ The URL format for the NIPs is https://github.com/nostr-protocol/nips/blob/maste | |||||
|
|
||||||
| ## Pull Requests | ||||||
|
|
||||||
| - Use the pull request template at `.github/pull_request_template.md` and fill out all sections. | ||||||
| - Summarize the changes made and describe how they were tested. | ||||||
| - Include any limitations or known issues in the description. | ||||||
| - Add a "Network Access" section summarizing blocked domains if network requests were denied. | ||||||
| - Ensure all new features, modules, or dependencies are properly documented in the `README.md` file. | ||||||
| - Ensure all new features, modules, or dependencies are properly documented in the `README.md` file. | ||||||
| ## PR Quality Gate | ||||||
|
|
||||||
| - PR summaries must reference modified files with file path citations (e.g. `F:path/to/file.java†L1-L2`). | ||||||
| - PR titles and commit messages must follow the `type: description` naming format. | ||||||
| - Allowed types: feat, fix, docs, refactor, test, chore, ci, build, perf, style. | ||||||
| - The description should be a concise verb + object phrase (e.g., `refactor: Refactor auth middleware to async`). | ||||||
|
||||||
| - The description should be a concise verb + object phrase (e.g., `refactor: Refactor auth middleware to async`). | |
| - The description should be a concise verb + object phrase (e.g., `refactor: update auth middleware to async`). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| # Contributing to nostr-java | ||
|
|
||
| nostr-java implements the Nostr protocol. A complete index of current Nostr Implementation Possibilities (NIPs) is listed in [AGENTS.md](AGENTS.md). | ||
|
|
||
| ## Development Guidelines | ||
|
|
||
| - Run `mvn -q verify` from the repository root before committing. | ||
| - Use `rg` for code searches instead of `ls -R` or `grep -R`. | ||
| - PR titles and commit messages must follow the `type: description` format. | ||
| - Allowed types: `feat`, `fix`, `docs`, `refactor`, `test`, `chore`, `ci`, `build`, `perf`, `style`. | ||
| - The description must be a concise verb + object phrase (e.g., `refactor: Refactor auth middleware to async`). | ||
tcheeric marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| - Summaries in pull requests must cite file paths and include testing output. | ||
| - Open pull requests using the template at `.github/pull_request_template.md` and complete every section. | ||
|
|
||
| By following these conventions, contributors help keep the codebase maintainable and aligned with the Nostr specifications. | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The regex pattern
[A-Z][^\\s]*\\s+.+requires the description to start with an uppercase letter followed by non-whitespace characters, then whitespace, then more content. This will reject valid descriptions like 'update auth middleware' (lowercase 'update'). The pattern should be^(${types.join('|')}):\\s+[a-zA-Z].+to allow lowercase verbs.