Skip to content

ci: surface build errors in workflow #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tcheeric merged 2 commits into from
Aug 21, 2025
Merged

ci: surface build errors in workflow #398

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56995d9
ci: show build log errors
tcheeric Aug 21, 2025
6d7a130
Merge branch 'develop' into codex/update-ci-workflow-to-log-build-errors
tcheeric Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,14 @@ jobs:
distribution: 'temurin'
cache: 'maven'
- name: Build with Maven
id: build
run: ./mvnw -q verify |& tee build.log
Copy link

Copilot AI Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The |& operator is a bash-specific feature that may not be available in all shell environments. Consider using 2>&1 | tee build.log for better portability across different shells.

Suggested change
run: ./mvnw -q verify |& tee build.log
run: ./mvnw -q verify 2>&1 | tee build.log

Copilot uses AI. Check for mistakes.
- name: Show build log
if: failure()
run: |
set -o pipefail
./mvnw -q verify | tee build.log
echo "Build error"
grep '^\[ERROR\]' build.log || true
Copy link

Copilot AI Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The regex pattern ^\[ERROR\] assumes Maven's specific error message format. Consider making this more robust by also checking for other common error patterns or using Maven's built-in error reporting flags.

Suggested change
grep '^\[ERROR\]' build.log || true
egrep '^\[ERROR\]|BUILD FAILURE|Exception|Caused by:' build.log || true

Copilot uses AI. Check for mistakes.
echo "Build log tail"
tail -n 200 build.log
- name: Upload surefire reports
if: always()
uses: actions/upload-artifact@v4
Expand Down
Loading