Skip to content

Conversation

@tcheeric
Copy link
Owner

Summary

  • add reusable HTTP client provider with configurable timeouts
  • validate and normalize NIP-05 inputs and build URIs safely
  • cover validator success, mismatched keys, and network errors with unit tests

Testing

  • mvn -q verify (integration tests failed: Could not find a valid Docker environment)

https://chatgpt.com/codex/tasks/task_b_68a732cc4a18833192c6f56eebd8a6c0

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 58.33333% with 25 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...main/java/nostr/util/validator/Nip05Validator.java 56.86% 16 Missing and 6 partials ⚠️
...ava/nostr/util/http/DefaultHttpClientProvider.java 25.00% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@tcheeric tcheeric merged commit 6acec2c into develop Aug 21, 2025
3 of 4 checks passed
@tcheeric tcheeric deleted the codex/refactor-nip05validator-for-reusability-and-safety branch August 21, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants