Skip to content

Conversation

@tcheeric
Copy link
Owner

Summary

  • add explicit event serialization error handling with new EventEncodingException
  • wrap event encoding in message encoders to surface failures
  • add test for serialization failure scenarios

Testing

  • mvn -q verify (fails: Could not find a valid Docker environment)

https://chatgpt.com/codex/tasks/task_b_68a732af0b6c8331a84573f43730c08c

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 13.33333% with 13 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../event/message/CanonicalAuthenticationMessage.java 0.00% 7 Missing ⚠️
...rc/main/java/nostr/event/message/EventMessage.java 0.00% 5 Missing ⚠️
.../java/nostr/event/json/codec/BaseEventEncoder.java 66.66% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@tcheeric tcheeric merged commit c7c39f8 into develop Aug 21, 2025
2 of 3 checks passed
@tcheeric tcheeric deleted the codex/refactor-baseeventencoder-exception-handling branch August 21, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants