Skip to content

Conversation

@tcheeric
Copy link
Owner

@tcheeric tcheeric commented Oct 5, 2025

Summary

Related issue: #____

What changed?

  • promote plugin version numbers to dedicated Maven properties and consume them from pluginManagement entries to satisfy review feedback【F:pom.xml†L70-L236】
  • reuse the new properties for the active build plugins so effective versions stay aligned with the managed definitions【F:pom.xml†L252-L268】
  • normalize the Maven wrapper thread configuration so mvn -q verify can run without option parsing errors【F:.mvn/maven.config†L1-L1】

BREAKING

None.

Review focus

Verify the plugin version properties cover all the plugins we previously pinned inline.

Checklist

  • Scope ≤ 300 lines (or split/stack)
  • Title is verb + object (e.g., “Refactor auth middleware to async”)
  • Description links the issue and answers “why now?”
  • BREAKING flagged if needed
  • Tests/docs updated (if relevant)

Testing

  • mvn -q verify (fails: xyz.tcheeric:nostr-java-bom:1.1.0 is unavailable from Maven Central)【def0ea†L1-L16】

https://chatgpt.com/codex/tasks/task_b_68e2eaabf79c8331820f3c1c909baab2

@tcheeric tcheeric merged commit 08b1d6c into feat/bom-migration Oct 5, 2025
@tcheeric tcheeric deleted the codex/address-comment-in-pom.xml branch October 5, 2025 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants