-
Notifications
You must be signed in to change notification settings - Fork 26
docs/revamp-docs #451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
docs/revamp-docs #451
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
1a113d6
chore: bump version to 0.5.0
643539c
docs: Revamp docs, add streaming subscriptions guide, and add navigat…
b3a8b6d
docs: comprehensive documentation improvements and fixes
61fb3ab
docs: update relay URLs to use 398ja relay
5bfeb08
docs: remove redundant examples from CODEBASE_OVERVIEW.md
11a268b
chore: bump version to 0.5.1
d56ff99
docs: add PR document for documentation improvements
b8b65e1
docs(agents): enhance coding and documentation guidelines
66a1a6d
Merge branch 'develop' into docs/revamp-docs
tcheeric 3048ccf
chore: align module versions with 0.5.1
tcheeric File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
chore: bump version to 0.5.0
- Loading branch information
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The root POM now declares
<version>0.5.1</version>, but the shared property remains at0.5.0and each module POM still inherits the parent as0.5.0. This means submodules will continue to publish0.5.0artifacts while the aggregator and documentation claim 0.5.1, producing inconsistent coordinates and a broken BOM for consumers. Update the property and child<parent>versions to 0.5.1 so all modules are released under the same version.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@codex address this comment. Add the now removed nostr java version property, and set its value properly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary
nostr-java.versionproperty at0.5.1in the root POM to keep published coordinates consistent with the documented release. pom.xmlL60-L890.5.1, ensuring all artifacts are built and released with the new version. nostr-java-api/pom.xmlL1-L9 nostr-java-base/pom.xmlL1-L9 nostr-java-client/pom.xmlL1-L9 nostr-java-crypto/pom.xmlL1-L9 nostr-java-encryption/pom.xmlL1-L9 nostr-java-event/pom.xmlL1-L9 nostr-java-examples/pom.xmlL1-L9 nostr-java-id/pom.xmlL1-L9 nostr-java-util/pom.xmlL1-L9Testing
mvn -q verify(fails because thexyz.tcheeric:nostr-java-bom:1.1.0import POM is unavailable in Maven Central in this environment)View task →