style: fix Qodana findings (javadoc order, regex, redundant cast, com…

…mented code, generics)

nostr-java-api/src/main/java/nostr/api/EventNostr.java

@@ -79,7 +79,7 @@ public <U extends BaseMessage> U signAndSend() {
    * @param relays relay map (name -> URI)
    */
   public <U extends BaseMessage> U signAndSend(Map<String, String> relays) {
-    return (U) sign().send(relays);
+    return sign().send(relays);
   }
 
   /**

nostr-java-api/src/main/java/nostr/api/NIP44.java

@@ -12,11 +12,11 @@
 import nostr.event.tag.PubKeyTag;
 import nostr.id.Identity;
 
-@Slf4j
 /**
  * NIP-44 helpers (Encrypted DM with XChaCha20). Encrypt/decrypt content and DM events.
  * Spec: https://github.com/nostr-protocol/nips/blob/master/44.md
  */
+@Slf4j
 public class NIP44 extends EventNostr {
 
   /**

nostr-java-api/src/main/java/nostr/api/NIP46.java

@@ -17,11 +17,11 @@
 import nostr.event.impl.GenericEvent;
 import nostr.id.Identity;
 
-@Slf4j
 /**
  * NIP-46 helpers (Nostr Connect). Build app requests and signer responses.
  * Spec: https://github.com/nostr-protocol/nips/blob/master/46.md
  */
+@Slf4j
 public final class NIP46 extends EventNostr {
 
   public NIP46(@NonNull Identity sender) {

nostr-java-api/src/main/java/nostr/api/NIP57.java

@@ -175,7 +175,6 @@ public NIP57 createZapRequestEvent(
         null);
   }
 
-  @SneakyThrows
   /**
    * Create a zap receipt event (kind 9735) acknowledging a zap payment.
    *
@@ -185,6 +184,7 @@ public NIP57 createZapRequestEvent(
    * @param zapRecipient the zap recipient pubkey (p-tag)
    * @return this instance for chaining
    */
+  @SneakyThrows
   public NIP57 createZapReceiptEvent(
       @NonNull GenericEvent zapRequestEvent,
       @NonNull String bolt11,

nostr-java-api/src/main/java/nostr/api/NIP61.java

@@ -68,14 +68,14 @@ public NIP61 createNutzapInformationalEvent(
     return this;
   }
 
-  @SneakyThrows
   /**
    * Create a Nutzap event (kind 7374) from a structured payload.
    *
    * @param nutZap the structured Nutzap containing proofs, mint and optional target event
    * @param content optional human-readable content
    * @return this instance for chaining
    */
+  @SneakyThrows
   public NIP61 createNutzapEvent(@NonNull NutZap nutZap, @NonNull String content) {
 
     return createNutzapEvent(

nostr-java-client/src/main/java/nostr/client/springwebsocket/SpringWebSocketClient.java

@@ -25,14 +25,14 @@ public SpringWebSocketClient(
     this.relayUrl = relayUrl;
   }
 
-  @NostrRetryable
   /**
    * Sends the provided {@link BaseMessage} over the WebSocket connection.
    *
    * @param eventMessage the message to send
    * @return the list of responses from the relay
    * @throws IOException if an I/O error occurs while sending the message
    */
+  @NostrRetryable
   public List<String> send(@NonNull BaseMessage eventMessage) throws IOException {
     String json = eventMessage.encode();
     log.debug(

nostr-java-event/src/main/java/nostr/event/entities/CalendarContent.java

@@ -22,8 +22,7 @@
 
 @EqualsAndHashCode(callSuper = false)
 public class CalendarContent<T extends BaseTag> extends NIP42Content {
-  // @JsonProperty
-  // private final String id;
+
 
   // below fields mandatory
   @Getter private final IdentifierTag identifierTag;
@@ -166,9 +165,9 @@ public Optional<GeohashTag> getGeohashTag() {
     return getTagsByType(GeohashTag.class).stream().findFirst();
   }
 
-  private <T extends BaseTag> List<T> getTagsByType(Class<T> clazz) {
+  private <E extends BaseTag> List<E> getTagsByType(Class<E> clazz) {
     Tag annotation = clazz.getAnnotation(Tag.class);
-    List<T> list = getBaseTags(annotation).stream().map(clazz::cast).toList();
+    List<E> list = getBaseTags(annotation).stream().map(clazz::cast).toList();
     return list;
   }
 
@@ -178,7 +177,7 @@ private List<T> getBaseTags(@NonNull Tag type) {
     List<T> value = classTypeTagsMap.get(code);
     Optional<List<T>> value1 = Optional.ofNullable(value);
     List<T> baseTags = value1.orElse(Collections.emptyList());
-    return (List<T>) baseTags;
+    return baseTags;
   }
 
   private void addTag(@NonNull T baseTag) {

nostr-java-event/src/main/java/nostr/event/entities/CalendarRsvpContent.java

@@ -17,8 +17,7 @@
 @JsonDeserialize(builder = CalendarRsvpContentBuilder.class)
 @EqualsAndHashCode(callSuper = false)
 public class CalendarRsvpContent extends NIP42Content {
-  // @JsonProperty
-  // private final String id;
+
 
   // below fields mandatory
   @Getter private final IdentifierTag identifierTag;

nostr-java-event/src/main/java/nostr/event/entities/CashuWallet.java

@@ -25,10 +25,7 @@ public class CashuWallet {
 
   @EqualsAndHashCode.Include private String privateKey;
 
-  /*
-      @EqualsAndHashCode.Include
-      private String unit;
-  */
+
   private Set<CashuMint> mints;
   private Map<String, Set<Relay>> relays;
   private Set<CashuToken> tokens;

nostr-java-event/src/main/java/nostr/event/entities/ZapReceipt.java

@@ -9,8 +9,7 @@
 @Data
 @EqualsAndHashCode(callSuper = false)
 public class ZapReceipt implements JsonContent {
-  // @JsonIgnore
-  // private String id;
+
 
   @JsonProperty private String bolt11;
 

nostr-java-util/src/main/java/nostr/util/validator/Nip05Validator.java

@@ -43,7 +43,7 @@ public class Nip05Validator {
   @Builder.Default @JsonIgnore
   private final HttpClientProvider httpClientProvider = new DefaultHttpClientProvider();
 
-  private static final Pattern LOCAL_PART_PATTERN = Pattern.compile("^[a-zA-Z0-9-_\\.]+$");
+  private static final Pattern LOCAL_PART_PATTERN = Pattern.compile("^[a-zA-Z0-9-_.]+$");
   private static final Pattern DOMAIN_PATTERN = Pattern.compile("^[A-Za-z0-9.-]+(:\\d{1,5})?$");
   private static final ObjectMapper MAPPER_BLACKBIRD =
       JsonMapper.builder().addModule(new BlackbirdModule()).build();