fix: restore sender overrides in NIP-01 builder #485
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue: #____
Restored the ability for
NIP01EventBuilderto accept per-call senders so the builder can satisfy callers that need to override the default identity, addressing the review feedback.What changed?
NIP01EventBuildercovering override and fallback behavior.Testing
BREAKING
None.
Review focus
Please double-check that the overload placement and generics preserve backward compatibility and align with desired API surface.
Checklist
Network Access
No blocked domains encountered during this work.
https://chatgpt.com/codex/tasks/task_b_68ed9352511883319e4b975b168abe18