Skip to content

Conversation

@tcheeric
Copy link
Owner

Summary

Related issue: #____

What changed?

  • Replace explicit generic type arguments in NIP01EventBuilder factory invocations with the diamond operator for clarity.

BREAKING

Review focus

  • Ensure the type inference changes keep the same runtime behavior.

Checklist

  • Scope ≤ 300 lines (or split/stack)
  • Title is verb + object (e.g., “Refactor auth middleware to async”)
  • Description links the issue and answers “why now?”
  • BREAKING flagged if needed
  • Tests/docs updated (if relevant)

Testing

mvn -q verify
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[ERROR] Non-resolvable import POM: The following artifacts could not be resolved: xyz.tcheeric:nostr-java-bom:pom:1.1.8 (absent): Could not find artifact xyz.tcheeric:nostr-java-bom:pom:1.1.8 in central (https://repo.maven.apache.org/maven2) @ line 99, column 25
 @
[ERROR] The build could not read 1 project -> [Help 1]
[ERROR]
[ERROR]   The project xyz.tcheeric:nostr-java:1.0.0 (/workspace/nostr-java/pom.xml) has 1 error
[ERROR]     Non-resolvable import POM: The following artifacts could not be resolved: xyz.tcheeric:nostr-java-bom:pom:1.1.8 (absent): Could not find artifact xyz.tcheeric:nostr-java-bom:pom:1.1.8 in central (https://repo.maven.apache.org/maven2) @ line 99, column 25 -> [Help 2]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException
[ERROR] [Help 2] http://cwiki.apache.org/confluence/display/MAVEN/UnresolvableModelException

Known issues / limitations

  • Build currently fails because xyz.tcheeric:nostr-java-bom:1.1.8 is unavailable from Maven Central.

Network Access

  • No blocked domains encountered; Maven Central responded but lacked the requested artifact.

https://chatgpt.com/codex/tasks/task_b_68ed9365c9cc833195aab256adeae129

@tcheeric tcheeric merged commit 042d019 into chore/bump-version-1.0.2-SNAPSHOT Oct 14, 2025
@tcheeric tcheeric deleted the codex/address-code-comment-in-nip01eventbuilder-dtnalz branch October 14, 2025 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants