Add toggle display double press action and more #300
Conversation
Jared-Is-Coding
commented
Sep 16, 2025
Jared-Is-Coding
commented
- Allow double press to dim the display
- Delay other screen interactions until the screen is no longer dimmed
- Also sets the default double press action to opening the menu
- Add single press settings
- Add long press settings
- Add button press handler
- Add dimmed screen gesture handler
- Dynamically generated the menu contents to reclaim 16 widgets
- Add secondary stat switcher
- Remove duplicate widgets in secondary stats to reclaim some widgets
- Update handlers for secondary stat
- Bump version
Jared-Is-Coding
force-pushed
the
feature/stats-button-handlers
branch
from
f18b037 to
5e923f2
Compare
|
Can we split out the menu button stuff to another PR? It would be nice to be a separate commit as I'll essentially be undoing it when migrating to LVGL editor. |
| stat_display_options.primary_stat = (stat_display_options.primary_stat + 1) % 4; | ||
| } | ||
| else { | ||
| stat_display_options.primary_stat = (stat_display_options.primary_stat + 3) % 4; |
There was a problem hiding this comment.
Is the scroll left/right gone now? The thing I like about it being a carousel type control is that it's more discoverable and provides better feedback to the gesture. If switching it programmatically is desired, we could always just scroll it in code.
There was a problem hiding this comment.
I'm not sure what you're referring to here. I've never been able to switch the primary stat on any of my remotes. The secondary one, however, did scroll before but that used a lot of widgets. This was just pulling them into a single widget instead and reclaiming some widgets for use. Could you clarify?
There was a problem hiding this comment.
Ah sorry, I meant to comment on the secondary stat. I wouldn't worry about trying to reduce the number of components so much. There's other ways around it :)
There was a problem hiding this comment.
Ah sorry, I meant to comment on the secondary stat. I wouldn't worry about trying to reduce the number of components so much. There's other ways around it :)
Gotcha. I'm all ears... this seemed like the only way at the time, without moving the settings menu to code instead.
|
The settings page indicators now overflow. Might be time to shrink the size on them Edit |
|
Is it possible to ellipsis overflow on the select controls for the long text in the settings page? |
|
The update button isn't applicable to all pages of the about screen. Can we leave that in the version content as it was? |
|
|
||
| static const char *TAG = "PUBREMOTE-MENU_SCREEN"; | ||
|
|
||
| lv_obj_t *ui_MenuBackButton = NULL, *ui_MenuBackButtonLabel = NULL, *ui_MenuConnectButton = NULL, |
There was a problem hiding this comment.
These seem to be missing the stick navigation now
There was a problem hiding this comment.
These seem to be missing the stick navigation now
This is the last outstanding bug on this PR. I left you some notes in DM.
Jared-Is-Coding
force-pushed
the
feature/stats-button-handlers
branch
from
fea47c9 to
c784061
Compare
Rebased this PR on that.
I still think there may be a better place for this to live. Regardless, it currently doesn't work without the regular button background due to the dark text styling setting. Is there another option here?
Not seeing a setting for this anywhere - am I missing it? |
Jared-Is-Coding
force-pushed
the
feature/stats-button-handlers
branch
from
c784061 to
265daab
Compare
- Allow double press to dim the display - Delay other screen interactions until the screen is no longer dimmed
- Add single press settings - Add long press settings - Add button press handler - Add dimmed screen gesture handler - Dynamically generated the menu contents to reclaim 16 widgets
- Add secondary stat switcher - Remove duplicate widgets in secondary stats to reclaim some widgets - Update handlers for secondary stat
Jared-Is-Coding
force-pushed
the
feature/stats-button-handlers
branch
from
265daab to
d7c7334
Compare
2 participants
