Fix Saved Messages name in folder add/remove toast#30464
Open
mvanhorn wants to merge 1 commit intotelegramdesktop:devfrom
Open
Fix Saved Messages name in folder add/remove toast#30464mvanhorn wants to merge 1 commit intotelegramdesktop:devfrom
mvanhorn wants to merge 1 commit intotelegramdesktop:devfrom
Conversation
Use isSelf() check before peer->name() in ChangeFilterById's done callback, matching the pattern from main_window.cpp. Without this, the toast shows the user's real name instead of "Saved Messages".
|
|
Member
|
CLA? |
Author
|
|
Author
|
worked on desktop! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When adding or removing "Saved Messages" from a chat folder, the toast shows the user's real name instead of "Saved Messages."
The
ChangeFilterByIdcallback inchoose_filter_box.cpp:174captureshistory->peer->name()without checkingisSelf(). This fix adds the sameisSelf()guard used inmain_window.cpp:808-810:Fixes #30383
This contribution was developed with AI assistance (Claude Code).