Skip to content

Backport/edit style variations #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tellthemachines merged 2 commits into from
Jan 31, 2023
Merged

Backport/edit style variations #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c99dace
Add test for style variations
oandregal Jan 30, 2023
2c58b47
fixup
oandregal Jan 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 60 additions & 0 deletions tests/phpunit/tests/theme/wpThemeJson.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3595,6 +3595,66 @@ public function test_get_styles_for_block_with_content_width() {
$this->assertSame( $expected, $root_rules . $style_rules );
}

/**
* @ticket 57583
*/
public function test_get_styles_for_block_with_style_variations() {
$theme_json = new WP_Theme_JSON(
array(
'version' => 2,
'styles' => array(
'blocks' => array(
'core/quote' => array(
'variations' => array(
'plain' => array(
'color' => array(
'background' => 'hotpink',
),
'unregisteredProperty' => 'value'
),
),
),
),
),
),
);

// Validate structure is sanitized.
$expected_theme_json = array(
'version' => 2,
'styles' => array(
'blocks' => array(
'core/quote' => array(
'variations' => array(
'plain' => array(
'color' => array(
'background' => 'hotpink',
),
),
),
),
),
),
);
$sanitized_theme_json = $theme_json->get_raw_data();
$this->assertEqualSetsWithIndex( $expected_theme_json, $sanitized_theme_json );

// Validate styles are generated properly.
$metadata = array(
'path' => array( 'styles', 'blocks', 'core/quote' ),
'selector' => '.wp-block-quote',
'variations' => array(
array(
'path' => array( 'styles', 'blocks', 'core/quote', 'variations', 'plain' ),
'selector' => '.is-style-plain.is-style-plain.wp-block-quote',
),
),
);
$expected_styles = '.is-style-plain .is-style-plain .wp-block-quote{background-color: hotpink;}';
$actual_styles = $theme_json->get_styles_for_block( $metadata );
$this->assertSame( $expected_styles, $actual_styles );
}

/**
* @ticket 56611
*/
Expand Down