-
Notifications
You must be signed in to change notification settings - Fork 22
Add .NET SDK support to temporal-developer skill #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
5243c4a
Add .NET reference files for temporal-developer skill
donald-pinckney 6f5e7dc
Fix .NET alignment issues from self-review
donald-pinckney d338213
Fix .NET correctness issues from verification pass
donald-pinckney d80bd35
Update supported language references to include .NET
donald-pinckney 0114238
Edits to advanced features
donald-pinckney 2ee9c02
edits to determinism protection, and move the .editorconfig section
donald-pinckney 3709a85
missed one
donald-pinckney b41ecc6
edit determinism.md
donald-pinckney 7ae7afb
edit error-handling.md
donald-pinckney 4f19f25
edit gotchas.md
donald-pinckney c51d32b
edit patterns.md
donald-pinckney 3aa4ce7
edit versioning.md
donald-pinckney 2a38c83
edit observability.md
donald-pinckney 93388e5
fix metrics
donald-pinckney 54ce199
self-review round 1
donald-pinckney b4c958e
minor correctness fixed
donald-pinckney 9be5c85
Merge branch 'main' into add-dotnet
donald-pinckney 476f53b
Update references/dotnet/patterns.md
donald-pinckney 58bbf52
address comments, clarify reference to earlier code snippet
donald-pinckney 467fd27
clarify that operations are forbidden IN WORKFLOWS
donald-pinckney 014eb91
cleanup workflow cancellation handling example
donald-pinckney 76aa90a
add task token retrieval comment
donald-pinckney 744cf8d
update .net requirements
donald-pinckney 58f8972
Fix propagation of workflow cancellation
donald-pinckney File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix .NET correctness issues from verification pass
- patterns.md: Fix cancellation pattern to use official TemporalException.IsCanceledException(e) with detached CancellationTokenSource - advanced-features.md: Fix DI hosting example to use official AddHostedTemporalWorker(clientTargetHost:, clientNamespace:, taskQueue:) pattern Verified against official SDK README, API docs, and temporal-docs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Loading branch information
commit d3382136ed42464df6dcbedc28bdef12ac76938a
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.