Set data to a Tensor in Row/Column style

[AndreaCatania]

I can create a 2x2 Matrix in this way:

let mut matrix = Tensor::new(&[2, 2]);

I would like to set its data in row / column style, something like:

// Using a macro to generate the Index
matrix[get_index(1, 1)] = 1.0;

// Using a function
matrix.set(1, 1, 1.0);

I'm not able to find any function / macro to perform this kind of operation, there is a reason for this?
(In case I'm available to submit a PR to implement it).

[adamcrume]

I simply haven't had time to address this, yet, but I know it would make some things a lot more convenient. Have you considered exactly how it would work? I don't think a macro is necessary; you could implement get_index as a regular function, although it would need to take a slice of integers to support arbitrary tensor ranks. Since something like get_index would need to take the tensor shape as a parameter, it might make more sense to go ahead and create a method on Tensor like set(&mut self, index: &[u64], value: T).

[AndreaCatania]

Yep, a function works too. I'll submit a PR

…

On Sun, Oct 13, 2019, 20:32 Adam Crume ***@***.***> wrote: I simply haven't had time to address this, yet, but I know it would make some things a lot more convenient. Have you considered exactly how it would work? I don't think a macro is necessary; you could implement get_index as a regular function, although it would need to take a slice of integers to support arbitrary tensor ranks. Since something like get_index would need to take the tensor shape as a parameter, it might make more sense to go ahead and create a method on Tensor like set(&mut self, index: &[u64], value: T). — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#222?email_source=notifications&email_token=AB7UYR2BS2CGJ7TJAGYM3CTQONSSTA5CNFSM4I7OS6P2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBC4T5A#issuecomment-541444596>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB7UYR5KY4O2YD6QAPPADI3QONSSTANCNFSM4I7OS6PQ> .