Skip to content
This repository was archived by the owner on Jul 7, 2023. It is now read-only.

Conversation

martiansideofthemoon
Copy link
Contributor

@martiansideofthemoon martiansideofthemoon commented May 20, 2019

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no PR author has not signed CLA label May 20, 2019
@martiansideofthemoon
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes PR author has signed CLA and removed cla: no PR author has not signed CLA labels May 20, 2019
@afrozenator
Copy link
Contributor

Hey @martiansideofthemoon -- thanks so much for the fix, I'll merge this in shortly, but would it be easy to add a unit test too to check if the fix works?

@martiansideofthemoon
Copy link
Contributor Author

Hi @afrozenator, what kind of a unit test would be useful? Should I compare the shapes of the input / output?

@afrozenator
Copy link
Contributor

Thanks a lot again for doing this @martiansideofthemoon ! Merging this now.

@afrozenator afrozenator merged commit db02a3b into tensorflow:master Jun 7, 2019
@afrozenator
Copy link
Contributor

@martiansideofthemoon --

Hi @afrozenator, what kind of a unit test would be useful? Should I compare the shapes of the input / output?

Yes, anything to make sure that things run should be fine.

tensorflow-copybara pushed a commit that referenced this pull request Jun 7, 2019
PiperOrigin-RevId: 252137294
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes PR author has signed CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants