Skip to content
This repository was archived by the owner on Jul 7, 2023. It is now read-only.

Conversation

konradczechowski
Copy link
Contributor

Parameters set for rlmb with Rainbow - "rlmb_dqn_guess1_rainbow"

Note that there is a lot of common code between Rainbow and VanillaDQN. Most likely we want
to remove Vanilla DQN and only have Rainbow if experiments will confirm that the latter works. If we want to keep both Vanilla DQN and Rainbow, larger refactor is required. I left TODO for this in dopamine_connector.py

@googlebot googlebot added the cla: yes PR author has signed CLA label Jun 19, 2019
Copy link
Contributor

@lukaszkaiser lukaszkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lukaszkaiser lukaszkaiser merged commit ddf0ef2 into tensorflow:master Jun 19, 2019
tensorflow-copybara pushed a commit that referenced this pull request Jun 19, 2019
PiperOrigin-RevId: 254044123
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes PR author has signed CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants