Skip to content

[tfjs-data] Update webcam tests for [email protected] #1979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kangyizhang merged 8 commits into from
Sep 5, 2019
Merged

[tfjs-data] Update webcam tests for [email protected] #1979

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8d9fc76
prepare data for 1.2.9
Sep 5, 2019
32267ec
update test
Sep 5, 2019
1855a81
no restart in firefox browserstack
Sep 5, 2019
5d756a4
save
Sep 5, 2019
9eda37d
Merge branch 'master' into kangyi-data-1.2.9
Sep 5, 2019
cf76528
fix nit
Sep 5, 2019
1313785
Merge branch 'kangyi-data-1.2.9' of github.com:tensorflow/tfjs into k…
Sep 5, 2019
e8ee724
fix test
Sep 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix test
  • Loading branch information
kangyizhang committed Sep 5, 2019
commit e8ee724dab4bfa692cfc4ec9000459b348fef51f
2 changes: 1 addition & 1 deletion tfjs-data/src/iterators/webcam_iterator_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,11 +201,11 @@ describeBrowserEnvs('WebcamIterator', () => {
expect(result2.done).toBeTruthy();
expect(result2.value).toBeNull();

await webcamIterator.start();
// Skip validation when it's in Firefox and Mac OS, because BrowserStack for
// Firefox does not trigger the readyState event when restarting.
if (navigator.userAgent.search('Firefox') < 0 &&
navigator.userAgent.search('OS X') < 0) {
await webcamIterator.start();
await replaceHTMLVideoElementSource(videoElement);
const result3 = await webcamIterator.next();
expect(result3.done).toBeFalsy();
Expand Down