Skip to content

Conversation

@nsthorat
Copy link
Contributor

@nsthorat nsthorat commented Sep 6, 2019

NOTE: do not update this PR's branch with master.

The diff script now clones and the current branch and commit as well as master rewinded to the merge base of the current branch and master to only find changes against where the branch was created (only true for branches on the main repo).

For forks, we diff against tensorflow/tfjs:master.

Test PRs:

Note that this PR is behind tfjs-node version bump from 1.2.8 => 1.2.9

This change is Reviewable

@dsmilkov dsmilkov self-requested a review September 6, 2019 15:57
Copy link
Contributor

@dsmilkov dsmilkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @dsmilkov and @nsthorat)


scripts/diff.js, line 44 at r1 (raw file):

  branchName = exec(`git rev-parse --abbrev-ref HEAD`).stdout.trim();
}
console.log('commitSha: ', commitSha);

are the log statements useful (actionable) to keep?


scripts/diff.js, line 67 at r1 (raw file):

  exec(`git fetch origin ${mergeBase}`);
  exec(`git checkout ${mergeBase}`);
  console.log('mergeBase: ', mergeBase);

useful to keep the log?

Copy link
Contributor Author

@nsthorat nsthorat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @dsmilkov)


scripts/diff.js, line 44 at r1 (raw file):

Previously, dsmilkov (Daniel Smilkov) wrote…

are the log statements useful (actionable) to keep?

spoke offline -- going to keep these because if the script goes wrong these are useful for debugging


scripts/diff.js, line 67 at r1 (raw file):

Previously, dsmilkov (Daniel Smilkov) wrote…

useful to keep the log?

see above

@nsthorat nsthorat merged commit ea0df3f into master Sep 9, 2019
@nsthorat nsthorat deleted the diff branch September 9, 2019 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants