[tfjs-vis] Support custom tickLabels with duplicate values in heatmaps #2012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@caisq I finally got a chance to look at that long standing bug you reported. |
tafsiri
changed the title
nsthorat
reviewed
Sep 13, 2019
tfjs-vis/src/render/heatmap.ts
Outdated
| transposed.dispose(); | ||
| // Data validation | ||
| const {xTickLabels, yTickLabels} = data; | ||
| if (xTickLabels) { |
nsthorat
approved these changes
Sep 13, 2019
tfjs-vis/src/render/heatmap.ts
Outdated
| transposedShape}`); | ||
| // Note that we will only do a check on the first element of the second | ||
| // dimension. We do not protect users against passing in a ragged array. | ||
| if (yTickLabels) { |
| // Download the intermediate tensor values and | ||
| // dispose the transposed tensor. | ||
| const transposedValues = await transposed.array(); | ||
| transposed.dispose(); |
Contributor
There was a problem hiding this comment.
do you have memory unit tests for this stuff?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the code has also been simplified/refactored for clarity.
Heatmap Fix
Confusion matrix
This change is