fix file:// URLs on Windows #3436
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BUG In Node.js on Windows, file: URLs have three slashes before the
drive letter. For example:
file:///c:/Users/strager/[snip]/nsfwjs/model.json
When converting a file: URL to a file path, NodeFileSystem's router
incorrectly preserves one leading slash. This results in a
drive-relative path, which refers to a different file than intended.
This leads to errors down the road:
Error: Path C:\C:\Users\strager\[snip]\nsfwjs\model.json does not exist: loading failed
at C:\Users\strager\[snip]\node_modules\@tensorflow\tfjs-node\dist\io\file_system.js:67:23
Use Node.js' built-in functions for dealing with file: URLs instead of
hackily parsing them ourselves.
On POSIX systems, this commit should not change behavior.
Author
|
Ping! I still use this patch and I think it should be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG In Node.js on Windows, file: URLs have three slashes before the
drive letter. For example:
When converting a file: URL to a file path, NodeFileSystem's router
incorrectly preserves one leading slash. This results in a
drive-relative path, which refers to a different file than intended.
This leads to errors down the road:
Use Node.js' built-in functions for dealing with file: URLs instead of
hackily parsing them ourselves.
On POSIX systems, this commit should not change behavior.
This change is