-
Notifications
You must be signed in to change notification settings - Fork 2k
Allows extra flexibility to the location of libtensorflow downloads. #4747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
pyu10055
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution, looks good with couple minor comments.
tfjs-node/README.md
Outdated
| CDN_STORAGE="https://yourmirrorofchoice.com" yarn install <package> | ||
| ``` | ||
|
|
||
| 2. Set the environment variable `TFJS_NODE_CDN_STORAGE`. This has the same behavior as `CDN_STORAGE`, but introduced to prevent collisions with other npm packages that might use `CDN_STORAGE`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is bit duplicated, maybe better to add deprecation note on the CDN_STORAGE, since TFJS_NODE_CDN_STORAGE seems to be a better naming.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I agree. It would be great to deprecate the use of CDN_STORAGE. Is there an "official" way to do this other than to leave a note that CDN_STORAGE will be deprecated at some future date? I will do this now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can put the option 2 and 3 at the top and move the CDN_STORAGE to the end and indicate it as a deprecated options.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've completed this. Thanks.
|
@googlebot I signed it! |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
Specifically, modifies the `install.js`. Adds two more options to control `CDN_STORAGE` for modifying the base host: 1. TFJS_NODE_CDN_STORAGE env variable to help with any naming collisions with other packages that might be using `CDN_STORAGE` env variable. 2. TFJS_NODE_CDN_STORAGE in the `.npmrc` file Adds two options to control the `BASE_URI` for use cases where the url path doesn't match the default: 1. TJFS_NODE_BASE_URI env variable 2. TFJS_NODE_BASE_URI in the `.npmrc`
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
- Updates the priority of CDN_STORAGE to be behind the `TFJS_NODE_` prefix version. - Corrects minor errors in README.md.
pyu10055
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks you!
Specifically, modifies the
install.js.Adds two more options to control
CDN_STORAGEfor modifying the basehost:
with other packages that might be using
CDN_STORAGEenv variable..npmrcfileAdds two options to control the
BASE_URIfor use cases where theurl path doesn't match the default:
.npmrcTo see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is