Skip to content

Conversation

@PhillipAWells
Copy link
Contributor

@PhillipAWells PhillipAWells commented Feb 26, 2021

Attempting to install tfjs-node or tfjs-node-gpu on the Windows platform would always result in the following error:

> node scripts/install.js

CPU-windows-3.2.0.zip
* Downloading libtensorflow

* Building TensorFlow Node.js bindings
symlink ./lib/napi-v7 failed:  null

This is due to the original code not checking the error value on the result of the symlink call. A simple conditional on whether error is null or not fixes the problem.


This change is Reviewable

@google-cla google-cla bot added the cla: yes label Feb 26, 2021
Copy link
Collaborator

@pyu10055 pyu10055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pyu10055 pyu10055 merged commit 2e745c8 into tensorflow:master Feb 26, 2021
@PhillipAWells PhillipAWells deleted the fix_windows_installation branch February 27, 2021 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants