-
Notifications
You must be signed in to change notification settings - Fork 2k
Fix browserstack-benchmark build-deps #5438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix browserstack-benchmark build-deps #5438
Conversation
lina128
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
LGTM! I can send a followup PR so that the cloudbuild and yarn command use these local dependencies. |
|
After applying this PR, I'm still blocked at a later stage with below error messages (not related to this change): 1b0bda7dd/wasm-binaries.tbz2 failed: class com.google.devtools.build.lib.bazel.repository.downloader.UnrecoverableHttpException GET returned 404 Not Found |
lina128
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
I've updated this PR to make the browserstack-benchmark tool compatible with the latest Bazel changes. @gyagp, the error you're seeing is caused by the Bazel emsdk toolchain not working on Windows yet: emscripten-core/emsdk#814 (because the browserstack-benchmark tool depends on tfjs-backend-wasm). I'll take another look at that issue, since it also blocks any Windows build that depends on tfjs-backend-wasm. |
|
With the fixed emscripten toolchain (using #5998), I still got error as below: |
Some recent Bazel changes missed updating the browserstack-benchmark's
build-depsscript. This PR updates it.To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is