Skip to content

Conversation

@antonbabenko
Copy link
Member

@antonbabenko antonbabenko commented Feb 21, 2021

Each example may have different version requirements.

@bryantbiggs What do you think we can do as a workaround?

@bryantbiggs
Copy link
Member

ya, I'm not sure if I can do that and use pre-commit. we can treat each example separately + the module as a whole (meaning grab the min/max from the module and run the checks at the root of the project, and then do the same for each example - this allows us to pick up the different versions if there are any). for now I have added this #114 to only run validate on the minimum supported version, but all checks on the maximum supported version

@antonbabenko
Copy link
Member Author

Closing in favor of #114

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants