Skip to content

fix: Replace aws_iam_policy_attachment to aws_iam_role_policy_attachment #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antonbabenko merged 2 commits into from
Sep 11, 2021
Merged

fix: Replace aws_iam_policy_attachment to aws_iam_role_policy_attachment #195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96b1ddf
fix: replace aws_iam_policy_attachment to aws_iam_role_policy_attachment
wsim-plaid Sep 10, 2021
ec0ebfa
docs: Fixed docs
antonbabenko Sep 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -615,17 +615,17 @@ No modules.
| [aws_iam_policy.logs](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/iam_policy) | resource |
| [aws_iam_policy.tracing](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/iam_policy) | resource |
| [aws_iam_policy.vpc](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/iam_policy) | resource |
| [aws_iam_policy_attachment.additional_inline](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/iam_policy_attachment) | resource |
| [aws_iam_policy_attachment.additional_json](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/iam_policy_attachment) | resource |
| [aws_iam_policy_attachment.additional_jsons](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/iam_policy_attachment) | resource |
| [aws_iam_policy_attachment.async](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/iam_policy_attachment) | resource |
| [aws_iam_policy_attachment.dead_letter](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/iam_policy_attachment) | resource |
| [aws_iam_policy_attachment.logs](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/iam_policy_attachment) | resource |
| [aws_iam_policy_attachment.tracing](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/iam_policy_attachment) | resource |
| [aws_iam_policy_attachment.vpc](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/iam_policy_attachment) | resource |
| [aws_iam_role.lambda](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/iam_role) | resource |
| [aws_iam_role_policy_attachment.additional_inline](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/iam_role_policy_attachment) | resource |
| [aws_iam_role_policy_attachment.additional_json](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/iam_role_policy_attachment) | resource |
| [aws_iam_role_policy_attachment.additional_jsons](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/iam_role_policy_attachment) | resource |
| [aws_iam_role_policy_attachment.additional_many](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/iam_role_policy_attachment) | resource |
| [aws_iam_role_policy_attachment.additional_one](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/iam_role_policy_attachment) | resource |
| [aws_iam_role_policy_attachment.async](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/iam_role_policy_attachment) | resource |
| [aws_iam_role_policy_attachment.dead_letter](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/iam_role_policy_attachment) | resource |
| [aws_iam_role_policy_attachment.logs](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/iam_role_policy_attachment) | resource |
| [aws_iam_role_policy_attachment.tracing](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/iam_role_policy_attachment) | resource |
| [aws_iam_role_policy_attachment.vpc](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/iam_role_policy_attachment) | resource |
| [aws_lambda_event_source_mapping.this](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/lambda_event_source_mapping) | resource |
| [aws_lambda_function.this](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/lambda_function) | resource |
| [aws_lambda_function_event_invoke_config.this](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/lambda_function_event_invoke_config) | resource |
Expand Down
40 changes: 16 additions & 24 deletions iam.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,11 +101,10 @@ resource "aws_iam_policy" "logs" {
tags = var.tags
}

resource "aws_iam_policy_attachment" "logs" {
resource "aws_iam_role_policy_attachment" "logs" {
count = local.create_role && var.attach_cloudwatch_logs_policy ? 1 : 0

name = "${local.role_name}-logs"
roles = [aws_iam_role.lambda[0].name]
role = aws_iam_role.lambda[0].name
policy_arn = aws_iam_policy.logs[0].arn
}

Expand Down Expand Up @@ -138,11 +137,10 @@ resource "aws_iam_policy" "dead_letter" {
tags = var.tags
}

resource "aws_iam_policy_attachment" "dead_letter" {
resource "aws_iam_role_policy_attachment" "dead_letter" {
count = local.create_role && var.attach_dead_letter_policy ? 1 : 0

name = "${local.role_name}-dl"
roles = [aws_iam_role.lambda[0].name]
role = aws_iam_role.lambda[0].name
policy_arn = aws_iam_policy.dead_letter[0].arn
}

Expand All @@ -165,11 +163,10 @@ resource "aws_iam_policy" "vpc" {
tags = var.tags
}

resource "aws_iam_policy_attachment" "vpc" {
resource "aws_iam_role_policy_attachment" "vpc" {
count = local.create_role && var.attach_network_policy ? 1 : 0

name = "${local.role_name}-vpc"
roles = [aws_iam_role.lambda[0].name]
role = aws_iam_role.lambda[0].name
policy_arn = aws_iam_policy.vpc[0].arn
}

Expand All @@ -192,11 +189,10 @@ resource "aws_iam_policy" "tracing" {
tags = var.tags
}

resource "aws_iam_policy_attachment" "tracing" {
resource "aws_iam_role_policy_attachment" "tracing" {
count = local.create_role && var.attach_tracing_policy ? 1 : 0

name = "${local.role_name}-tracing"
roles = [aws_iam_role.lambda[0].name]
role = aws_iam_role.lambda[0].name
policy_arn = aws_iam_policy.tracing[0].arn
}

Expand Down Expand Up @@ -229,11 +225,10 @@ resource "aws_iam_policy" "async" {
tags = var.tags
}

resource "aws_iam_policy_attachment" "async" {
resource "aws_iam_role_policy_attachment" "async" {
count = local.create_role && var.attach_async_event_policy ? 1 : 0

name = "${local.role_name}-async"
roles = [aws_iam_role.lambda[0].name]
role = aws_iam_role.lambda[0].name
policy_arn = aws_iam_policy.async[0].arn
}

Expand All @@ -249,11 +244,10 @@ resource "aws_iam_policy" "additional_json" {
tags = var.tags
}

resource "aws_iam_policy_attachment" "additional_json" {
resource "aws_iam_role_policy_attachment" "additional_json" {
count = local.create_role && var.attach_policy_json ? 1 : 0

name = local.role_name
roles = [aws_iam_role.lambda[0].name]
role = aws_iam_role.lambda[0].name
policy_arn = aws_iam_policy.additional_json[0].arn
}

Expand All @@ -269,11 +263,10 @@ resource "aws_iam_policy" "additional_jsons" {
tags = var.tags
}

resource "aws_iam_policy_attachment" "additional_jsons" {
resource "aws_iam_role_policy_attachment" "additional_jsons" {
count = local.create_role && var.attach_policy_jsons ? var.number_of_policy_jsons : 0

name = "${local.role_name}-${count.index}"
roles = [aws_iam_role.lambda[0].name]
role = aws_iam_role.lambda[0].name
policy_arn = aws_iam_policy.additional_jsons[count.index].arn
}

Expand Down Expand Up @@ -353,10 +346,9 @@ resource "aws_iam_policy" "additional_inline" {
tags = var.tags
}

resource "aws_iam_policy_attachment" "additional_inline" {
resource "aws_iam_role_policy_attachment" "additional_inline" {
count = local.create_role && var.attach_policy_statements ? 1 : 0

name = local.role_name
roles = [aws_iam_role.lambda[0].name]
role = aws_iam_role.lambda[0].name
policy_arn = aws_iam_policy.additional_inline[0].arn
}