Skip to content

fix: Removed hard-coded AWS account id in examples #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antonbabenko merged 2 commits into from
Mar 28, 2022
Merged

fix: Removed hard-coded AWS account id in examples #275

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d0754f
Removed hardcoded AWS account and added data resource to lookup curre…
msharma24 Mar 4, 2022
97a100f
Merge branch 'master' into fix/remove-hardcoded-aws-account-id
antonbabenko Mar 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Removed hardcoded AWS account and added data resource to lookup curre… 
…nt aws account
  • Loading branch information
@msharma24
msharma24 committed Mar 4, 2022
commit 9d0754f5b4e2d2a0827015aa38d9fed2b8d58e6b
10 changes: 6 additions & 4 deletions examples/complete/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ provider "aws" {
skip_requesting_account_id = true
}

data "aws_caller_identity" "current" {}

####################################################
# Lambda Function (building locally, storing on S3,
# set allowed triggers, set policies)
Expand Down Expand Up @@ -51,15 +53,15 @@ module "lambda_function" {
allowed_triggers = {
APIGatewayAny = {
service = "apigateway"
source_arn = "arn:aws:execute-api:eu-west-1:135367859851:aqnku8akd0/*/*/*"
source_arn = "arn:aws:execute-api:eu-west-1:${data.aws_caller_identity.current.account_id}:aqnku8akd0/*/*/*"
},
APIGatewayDevPost = {
service = "apigateway"
source_arn = "arn:aws:execute-api:eu-west-1:135367859851:aqnku8akd0/dev/POST/*"
source_arn = "arn:aws:execute-api:eu-west-1:${data.aws_caller_identity.current.account_id}:aqnku8akd0/dev/POST/*"
},
OneRule = {
principal = "events.amazonaws.com"
source_arn = "arn:aws:events:eu-west-1:135367859851:rule/RunDaily"
source_arn = "arn:aws:events:eu-west-1:${data.aws_caller_identity.current.account_id}:rule/RunDaily"
}
}

Expand All @@ -74,7 +76,7 @@ module "lambda_function" {
principals = {
account_principal = {
type = "AWS",
identifiers = ["arn:aws:iam::135367859851:root"]
identifiers = ["arn:aws:iam::${data.aws_caller_identity.current.account_id}:root"]
}
}
condition = {
Expand Down